Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(374): add full JsonPlaceholder configuration #390

Conversation

onyedikachi-david
Copy link
Contributor

@onyedikachi-david onyedikachi-david commented Jul 24, 2024

Add a comprehensive Tailcall configuration for JsonPlaceholder API,
including GraphQL, YAML, and JSON versions. Implement relationships
between types using @call directive and validate configurations via
Tailcall CLI.

Fixes: #374
/claim #374

@onyedikachi-david
Copy link
Contributor Author

Please review @tusharmath

@tusharmath tusharmath marked this pull request as draft July 26, 2024 06:30
@tusharmath
Copy link
Contributor

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

@onyedikachi-david onyedikachi-david marked this pull request as ready for review July 30, 2024 17:12
@onyedikachi-david
Copy link
Contributor Author

@tusharmath I just implemented requested changes. Please review.

@tusharmath
Copy link
Contributor

@tusharmath
Copy link
Contributor

The configuration is becoming too big I think it would be better to raise a PR wrt to https://github.com/tailcallhq/tailcall/blob/main/examples/jsonplaceholder.graphql

And then on the website give a link to the raw URL — https://raw.githubusercontent.com/tailcallhq/tailcall/main/examples/jsonplaceholder.graphql

@tusharmath tusharmath marked this pull request as draft August 11, 2024 11:15
@tusharmath
Copy link
Contributor

Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.

Copy link
Contributor Author

@onyedikachi-david onyedikachi-david left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration is becoming too big I think it would be better to raise a PR wrt to https://github.com/tailcallhq/tailcall/blob/main/examples/jsonplaceholder.graphql

And then on the website give a link to the raw URL — https://raw.githubusercontent.com/tailcallhq/tailcall/main/examples/jsonplaceholder.graphql

Just for graphql or json and yml too?

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
@onyedikachi-david onyedikachi-david changed the title feat(config): add full JsonPlaceholder configuration feat(374): add full JsonPlaceholder configuration Aug 21, 2024
@onyedikachi-david
Copy link
Contributor Author

The configuration is becoming too big I think it would be better to raise a PR wrt to https://github.com/tailcallhq/tailcall/blob/main/examples/jsonplaceholder.graphql

And then on the website give a link to the raw URL — https://raw.githubusercontent.com/tailcallhq/tailcall/main/examples/jsonplaceholder.graphql

Done.

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
@onyedikachi-david onyedikachi-david marked this pull request as ready for review August 21, 2024 12:40
@tusharmath
Copy link
Contributor

/tip $10

Not a priority at the moment. Closing this PR for now. Thank you for your efforts!

@tusharmath tusharmath closed this Oct 3, 2024
Copy link

algora-pbc bot commented Oct 3, 2024

🎉🎈 @onyedikachi-david has been awarded $10! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the tailcall configuration on Getting Started section with the complete JsonPlaceholder configuration
2 participants