[tailscale1.20] .github/workflows: add a static build for testing. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only x86 linux for now, to try out using a static toolchain. Signed-off-by: David Anderson <dave@natulte.net>
bradfitz
approved these changes
Feb 2, 2023
| - name: build | ||
| run: cd src && ./make.bash | ||
| env: | ||
| CGO_ENABLED: "0" |
There was a problem hiding this comment.
I think just doing this will be too problematic on callers (casual developers in the tree ... we can't just force it back to true easily. We want to have the same magic behavior as not setting)
So I think we want to modify our Go tree as well.
But you can start with this and see.
There was a problem hiding this comment.
I want this right now so I can try to update all our toolchain goop to use static builds and see if I can make it all work out. If it does, we can tweak the default behavior before rolling it out more, yeah.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only x86 linux for now, to try out using a static toolchain.
Signed-off-by: David Anderson dave@natulte.net