Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add command to start emulator #343

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Makefile: add command to start emulator #343

merged 1 commit into from
Sep 13, 2024

Conversation

kari-ts
Copy link
Collaborator

@kari-ts kari-ts commented Apr 18, 2024

No description provided.

@kari-ts kari-ts requested a review from raggi April 18, 2024 20:59
@raggi
Copy link
Member

raggi commented Apr 18, 2024

Why prefer an arm image? That'll be slow on x86 machines?

See https://github.com/tailscale/tailscale-android/pull/134/files for another method, this also explicitly picks a google apis image

@kari-ts
Copy link
Collaborator Author

kari-ts commented Apr 18, 2024

Updated to not prefer ARM. https://github.com/tailscale/tailscale-android/pull/134/files didn't quite work for me since uname -u returns arm64 for me

@raggi raggi force-pushed the kari/em branch 3 times, most recently from 3a83647 to c636a5e Compare September 13, 2024 22:18
raggi added a commit that referenced this pull request Sep 13, 2024
This emulator command starts an emulator and keeps running in the
foreground so as to avoid creating zombies.

Updates #343

Co-authored-by: kari@tailscale.com
This emulator command starts an emulator and keeps running in the
foreground so as to avoid creating zombies.

Updates #343

Co-authored-by: kari@tailscale.com
Signed-off-by: James Tucker <james@tailscale.com>
@raggi raggi merged commit 72c4104 into main Sep 13, 2024
4 checks passed
@raggi raggi deleted the kari/em branch September 13, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants