Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipn: provide subtitle in QuickToggleService #357

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

agottardo
Copy link
Collaborator

Fixes ENG-3443

As discussed during design review, provides a "Connected" / "Not connected" subtitle in the Tailscale quick tile.

Also drops unnecessary SDK version checks in App.kt.

@agottardo agottardo added the enhancement New feature or request label Apr 29, 2024
@agottardo agottardo self-assigned this Apr 29, 2024
@oxtoacart
Copy link
Contributor

This may not be new to this PR, but on my Galaxy S23 running Android 14, I see the below problem.

  1. Turn on Tailscale
  2. Connect to VPN
  3. Stop Tailscale (don't disconnect, just stop the app, for example using "Force Quit"). This way, the next time you start Tailscale it'll automatically connect to VPN.
  4. Make sure you've enabled our Quick Settings tile
  5. Start Tailscale
  6. See that Tailscale automatically connects to Tailnet
  7. Look at Quick Settings tile and see that styling and text indicate it is disconnected

@agottardo
Copy link
Collaborator Author

This may not be new to this PR, but on my Galaxy S23 running Android 14, I see the below problem.

  1. Turn on Tailscale
  2. Connect to VPN
  3. Stop Tailscale (don't disconnect, just stop the app, for example using "Force Quit"). This way, the next time you start Tailscale it'll automatically connect to VPN.
  4. Make sure you've enabled our Quick Settings tile
  5. Start Tailscale
  6. See that Tailscale automatically connects to Tailnet
  7. Look at Quick Settings tile and see that styling and text indicate it is disconnected

I'm opening a separate issue for this; I can also reproduce but I'm unfamiliar with the rest of the tile machinery.

Fixes ENG-3443

Provides a "Connected" / "Not connected" subtitle in the Tailscale quick tile.

Also drops unnecessary SDK version checks in App.kt.

Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
@agottardo agottardo merged commit 427e2d2 into main Apr 29, 2024
3 checks passed
@agottardo agottardo deleted the angott/ENG-3443 branch April 29, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants