java: format strings containing integers in ROOT locale. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a phone with a Saudi Arabian or another similar locale available to try. This doesn't break the US locale, and should fix locales using Indian-Arabic numerals. |
|
Is this PR meant to be bumping versions of things and disabling vulkan? Seems unrelated |
|
Created the branch from the wrong place. |
bradfitz
approved these changes
Mar 13, 2022
There was a problem hiding this comment.
I think you want Locale.ROOT, though, which is like locale "C" in C.
The root locale is the locale whose language, country, and variant are empty ("") strings. This is regarded as the base locale of all locales, and is used as the language/country neutral locale for the locale sensitive operations.
We use strings to pass structured data from the JVM to Go. In a locale using Indian-Arabic numerals: ۰ ۱ ۲ ۳ ۴ ۵ ۶ ۷ ۸ ۹ the Java code will format decimal strings using Indian-Arabic glyphs. Go doesn't get a locale set automatically by the Android runtime, so it always parses strings in a default en-US `unable to parse "lo ١ ٦٥٥٣٦ true false true false false |": expected integer` Make the Java code format using the ROOT locale. These strings are purely internal to pass between the two runtimes, they are not shown to the user. Fixes tailscale/tailscale#4156 Signed-off-by: Denton Gentry <dgentry@tailscale.com>
DentonGentry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use strings to pass structured data from the JVM to Go.
In a locale using Indian-Arabic numerals: ۰ ۱ ۲ ۳ ۴ ۵ ۶ ۷ ۸ ۹
the Java code will format decimal strings using Indian-Arabic
glyphs.
Go doesn't get a locale set automatically by the Android
runtime, so it always parses strings in a default en-US
unable to parse "lo ١ ٦٥٥٣٦ true false true false false |": expected integerMake the Java code format using the ROOT locale. These strings
are purely internal to pass between the two runtimes, they are
not shown to the user.
Fixes tailscale/tailscale#4156
Signed-off-by: Denton Gentry dgentry@tailscale.com