Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Amazon S3 accesspoints #579

Open
jakepage91 opened this issue Mar 7, 2023 · 18 comments
Open

Support Amazon S3 accesspoints #579

jakepage91 opened this issue Mar 7, 2023 · 18 comments
Assignees
Labels
aws enhancement New feature or request feature good first issue Good for newcomers

Comments

@jakepage91
Copy link
Contributor

Describe the solution you'd like
Collect Amazon S3 accesspoints
Additional context
To get an idea of how to implement the collector, take the S3 buckets resource as inspiration.

@jakepage91 jakepage91 added enhancement New feature or request good first issue Good for newcomers feature aws labels Mar 7, 2023
@aimanafzal
Copy link
Contributor

Hi @jakepage91 , Let me work on this.

@jakepage91
Copy link
Contributor Author

For sure! Yours.

@aimanafzal
Copy link
Contributor

Thanks 👍

@ShubhamPalriwala
Copy link
Contributor

Hey @aimanafzal, would you like to continue working on this now since the ECS Task Definition PR is almost ready to be merged 😉 ?

@aimanafzal
Copy link
Contributor

aimanafzal commented Jul 8, 2023 via email

@ShubhamPalriwala
Copy link
Contributor

Hey, the issue is open and is already assigned to you! Please open a PR whenever you are ready with it, looking forward to it 😄

@aimanafzal
Copy link
Contributor

Hey, the issue is open and is already assigned to you! Please open a PR whenever you are ready with it, looking forward to it 😄

Starting to work on it

@aimanafzal
Copy link
Contributor

Hey, the issue is open and is already assigned to you! Please open a PR whenever you are ready with it, looking forward to it 😄

Starting to work on it

@ShubhamPalriwala I don't see the service in the list. Even though I have got the policy updated in my AWS.
Is there anything that I am doing wrong?

@aimanafzal
Copy link
Contributor

Hey, the issue is open and is already assigned to you! Please open a PR whenever you are ready with it, looking forward to it 😄

Starting to work on it

@ShubhamPalriwala I don't see the service in the list. Even though I have got the policy updated in my AWS. Is there anything that I am doing wrong?

@jakepage91 @ShubhamPalriwala

@ShubhamPalriwala
Copy link
Contributor

Hey @aimanafzal, I couldn't understand you! are you asking about where to find the Access Points? Does this help then:
https://aws.amazon.com/s3/features/access-points/?

@aimanafzal
Copy link
Contributor

Hey @aimanafzal, I couldn't understand you! are you asking about where to find the Access Points? Does this help then: https://aws.amazon.com/s3/features/access-points/?

No, it is not that. I mean, on the Komiser screen. It is not showing up.
I have checked the policy and it should be fine.

@mlabouardy
Copy link
Collaborator

Hey @aimanafzal, I couldn't understand you! are you asking about where to find the Access Points? Does this help then: https://aws.amazon.com/s3/features/access-points/?

No, it is not that. I mean, on the Komiser screen. It is not showing up. I have checked the policy and it should be fine.

do you've any S3 access points created in your AWS account? what's the output of this command.

@aimanafzal
Copy link
Contributor

aimanafzal commented Aug 15, 2023 via email

@jakepage91
Copy link
Contributor Author

Hey there @aimanafzal I really apologize! We seem to have lost the thread here on this issue in the last few weeks! I wanted to revisit this to see exactly where you got stuck. Could give me a refresher? So I can best help you out.

@aimanafzal
Copy link
Contributor

Hey @jakepage91, Thanks for reaching out.

The issue is, that I don't see the service in the list on my screen. Even though I have got the policy updated in my AWS.

@jakepage91
Copy link
Contributor Author

Hey there @aimanafzal do you see any fetched S3 accesspoints in the CLI which then don't appear in the cloud inventory or you don't even see them being fetched through the CLI?

@aimanafzal
Copy link
Contributor

aimanafzal commented Oct 26, 2023 via email

@aimanafzal
Copy link
Contributor

@jakepage91 Did you checked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws enhancement New feature or request feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants