-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Amazon S3 accesspoints #579
Comments
Hi @jakepage91 , Let me work on this. |
For sure! Yours. |
Thanks 👍 |
Hey @aimanafzal, would you like to continue working on this now since the ECS Task Definition PR is almost ready to be merged 😉 ? |
Yes, please open this issue too :)
Both could be done at almost the same time.
On 07-Jul-2023, at 10:26 PM, Shubham Palriwala ***@***.***> wrote:
Hey @aimanafzal<https://github.com/aimanafzal>, would you like to continue working on this now since the ECS Task Definition PR is almost ready to be merged 😉 ?
—
Reply to this email directly, view it on GitHub<#579 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDSA72XBFNGKCQ7GP33KTLXPBBETANCNFSM6AAAAAAVSSLWTY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hey, the issue is open and is already assigned to you! Please open a PR whenever you are ready with it, looking forward to it 😄 |
Starting to work on it |
@ShubhamPalriwala I don't see the service in the list. Even though I have got the policy updated in my AWS. |
|
Hey @aimanafzal, I couldn't understand you! are you asking about where to find the Access Points? Does this help then: |
No, it is not that. I mean, on the Komiser screen. It is not showing up. |
do you've any S3 access points created in your AWS account? what's the output of this command. |
Yes, there is.
On 14-Aug-2023, at 5:58 PM, LABOUARDY Mohamed ***@***.***> wrote:
Hey @aimanafzal<https://github.com/aimanafzal>, I couldn't understand you! are you asking about where to find the Access Points? Does this help then: https://aws.amazon.com/s3/features/access-points/?
No, it is not that. I mean, on the Komiser screen. It is not showing up. I have checked the policy and it should be fine.
do you've any S3 access points created in your AWS account? what's the output of this command<https://docs.aws.amazon.com/cli/latest/reference/s3control/list-access-points.html>.
—
Reply to this email directly, view it on GitHub<#579 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDSA72DYHNKCZ4KKV3TZH3XVIOJFANCNFSM6AAAAAAVSSLWTY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hey there @aimanafzal I really apologize! We seem to have lost the thread here on this issue in the last few weeks! I wanted to revisit this to see exactly where you got stuck. Could give me a refresher? So I can best help you out. |
Hey @jakepage91, Thanks for reaching out. The issue is, that I don't see the service in the list on my screen. Even though I have got the policy updated in my AWS. |
Hey there @aimanafzal do you see any fetched S3 accesspoints in the CLI which then don't appear in the cloud inventory or you don't even see them being fetched through the CLI? |
Only S3 as a service is visible.
On 26-Oct-2023, at 3:08 PM, Jake Page ***@***.***> wrote:
Hey there @aimanafzal<https://github.com/aimanafzal> do you see any fetched S3 accesspoints in the CLI which then don't appear in the cloud inventory or you don't even see them being fetched through the CLI?
—
Reply to this email directly, view it on GitHub<#579 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACDSA77B7SBFBDKZHTNBE4TYBIZCFAVCNFSM6AAAAAAVSSLWT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBQHAYTGMBTGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@jakepage91 Did you checked? |
Describe the solution you'd like
Collect Amazon S3 accesspoints
Additional context
To get an idea of how to implement the collector, take the S3 buckets resource as inspiration.
The text was updated successfully, but these errors were encountered: