Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus styles showing up when using the mouse #2347

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Fix focus styles showing up when using the mouse #2347

merged 5 commits into from
Mar 10, 2023

Commits on Mar 10, 2023

  1. update playground examples to use a shared Button

    @RobinMalfait
    RobinMalfait committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e1b7106 View commit details
    Browse the repository at this point in the history

  2. expose a ui-focus-visible variant

    @RobinMalfait
    RobinMalfait committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    39fa873 View commit details
    Browse the repository at this point in the history

  3. keep track of a data-headlessui-focus-visible attribute

    @RobinMalfait
    RobinMalfait committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    fe6165b View commit details
    Browse the repository at this point in the history

  4. do not set the tabindex 

    The focus was always set, but the ring wasn't showing up. This was also
focusing a ring when the browser decided not the add one.

Let's make the browser decide when to show this or not.
    @RobinMalfait
    RobinMalfait committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    c0bec1f View commit details
    Browse the repository at this point in the history

  5. update changelog

    @RobinMalfait
    RobinMalfait committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    555c062 View commit details
    Browse the repository at this point in the history