Use correct value when resetting <Listbox multiple> and <Combobox multiple>
#2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It thought it was always controlled which broke things
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when:
<Listbox multiple>or<Combobox multiple>; ANDdefaultValue={['bob']}); AND<form>element; ANDresetbuttonWe would incorrectly push the array default value as an entry to the internal value array instead of replacing it. This fixes that problem.
Additionally, while working on this, we discovered that both uncontrolled
<Listbox multiple>and<Combobox multiple>did not output form elements in Vue because they were incorrectly determined to be controlled. This PR fixes this as well.Fixes #2603