-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dialog
cycling
#553
Fix Dialog
cycling
#553
Conversation
This pull request is being automatically deployed with Vercel (learn more). headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/Ej7YjE1QVwEKHcLNs4yshVvvy2xK headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/o6gLp7cUf35tWrn5tFgUDecNwVqR |
d9fc767
to
ba6f251
Compare
Any update on this MR ? We are facing the same issue. Thanks! |
Any more updates in this? I just ran into this issue myself. |
ba6f251
to
03e70ca
Compare
0a93ef4
to
cbcc014
Compare
@francoismassart @ZusorCode This should be fixed, and will be available in the next release. You can already try it using |
This fixed the issue I was having, thank you! |
Hi guys, do you have any idea when the next release will be available? |
This PR technically fixes 2 issues. I started by making the Vue code similar to the React code to have as much similarities between the 2 codebases. This should make things easier in the future when adding features or fixing bugs. Because of this, we implemented the "nested dialogs" feature.
By doing this, we also fixed the actual issue this is fixing, which is when you add the
initialFocus
ref, then the Tab Lock was broken. This is fixed now.It took a while, since the PR has been open for a few months... but we are ready now!
Fixes: #542