Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type declarations for vue #254

Merged
merged 3 commits into from
Jul 26, 2021
Merged

feat: type declarations for vue #254

merged 3 commits into from
Jul 26, 2021

Conversation

VottusCode
Copy link
Contributor

@VottusCode VottusCode commented Apr 18, 2021 •
edited
Loading

fixes #252

Until this is merged, I've published a package heroicons-vue3,
which will be deprecated (but will continue to work, however unmaintained) once it is merged. If you need to use Heroicons with Vue 3 now, you can use that for the time being.

@VottusCode
Copy link
Contributor Author

Can this be merged, please?

@VottusCode VottusCode mentioned this pull request May 20, 2021
Closed
@callamd
Copy link

callamd commented May 20, 2021

This fixes broken support for tailwind UI and was approved a month ago. Pls merge.

@bartenra bartenra mentioned this pull request Jul 8, 2021
Closed
@davidmatter
Copy link

@bradlc @dacoto97 can we have a merge here? :)

@VottusCode
Copy link
Contributor Author

no idea

@bartenra bartenra mentioned this pull request Jul 21, 2021
Closed
@bartenra
Copy link

Pinging @bradlc and @adamwathan again.

@VottusCode
Copy link
Contributor Author

@bradlc @adamwathan Please can you merge this?

@RobinMalfait
Copy link
Member

Hey! Thank you for your PR!
Much appreciated! 🙏

Sorry for the delay!

@RobinMalfait RobinMalfait merged commit 56703ae into tailwindlabs:master Jul 26, 2021
zmwangx added a commit to zmwangx/heroicons that referenced this pull request Aug 1, 2021
@zmwangx
Fix vue TS declarations
8c6bd52 
The declarations generated by tailwindlabs#254 aren't correct, leading to tsc errors as
seen in tailwindlabs#318.
@zmwangx zmwangx mentioned this pull request Aug 1, 2021
Merged
bradlc added a commit that referenced this pull request Aug 17, 2021
@zmwangx @bradlc
Fix vue TypeScript declarations (#322)
2d3a08a 
* Fix vue TS declarations

The declarations generated by #254 aren't correct, leading to tsc errors as
seen in #318.

* Use `RenderFunction` instead of `DefineComponent`

Co-authored-by: Brad Cornes <bradlc41@gmail.com>
@vAHiD55555 vAHiD55555 mentioned this pull request Jun 20, 2024
Open
@adamicska adamicska mentioned this pull request Sep 1, 2024
Open
This was referenced Sep 11, 2024
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacoto97 dacoto97 dacoto97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS7016: Could not find a declaration file for module '@heroicons/vue/solid'.
6 participants
@VottusCode @callamd @davidmatter @bartenra @RobinMalfait @dacoto97