Update jquery.fn.gantt.js #153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bugs: Weekly scale showing week zero in some situations (taitems#112) Weekly scale not showing correct number of weeks (52 or 53) (taitems#99) Daily scale showing day 1 inside the previous month group PS: This is my first GitHub contribuition, hope that I'm doing everything right.
|
Thanks for the contribution! I'll take a look over the next week, but going forward I think we want to avoid modifying the prototype of a host object (such as |
|
Good pull request @diogenesl, fixes some things I'm still looking at with the date handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs:
Weekly scale showing week zero in some situations (#112)
Weekly scale not showing correct number of weeks (52 or 53) (#99)
Daily scale showing day 1 inside the previous month group
PS: This is my first GitHub contribuition, hope that I'm doing everything right.