This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
feat(compat): add support for python 3.10 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though 3.10 is still in RC, there's a bunch of things they've already settled on which we need to tackle before being able to support it. Most noteably, a bunch of the deprecated usages of
loopfor asyncio have now been removed entirely, which means we'll need to update accordingly. Since >=3.6 supports removing this flag and 3.5 is already EOL'd, I've elected to drop support for 3.5 rather than maintain duplicate flows for all relevant code paths.A good chunk of this PR ended up being lint fixes; the test file needed to be split since pre-commit was whinging, the linters getting updated to py3.6 where able to migrate us to f-strings, and the now-unnecessary iter* "convenience" methods could be removed.
Note that, as this removes support for 3.5, it should be considered a breaking change.