Skip to content

improving cookie security #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2020
Merged

improving cookie security #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69a783e
improving cookie security
daghan Dec 31, 2019
5eb4a8b
improving cookie security, keeping httponly and samesite parameters, …
daghan Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/ch12-forms/final/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down
4 changes: 2 additions & 2 deletions app/ch13-validation/final/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down
4 changes: 2 additions & 2 deletions app/ch13-validation/starter/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down
4 changes: 2 additions & 2 deletions app/ch14_testing/final/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=True, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down
4 changes: 2 additions & 2 deletions app/ch14_testing/starter/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down
4 changes: 2 additions & 2 deletions app/ch15_deploy/final/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down
4 changes: 2 additions & 2 deletions app/ch15_deploy/starter/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down
4 changes: 2 additions & 2 deletions app/ch16_mongodb/final/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down
4 changes: 2 additions & 2 deletions app/ch16_mongodb/starter/pypi_org/infrastructure/cookie_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
def set_auth(response: Response, user_id: int):
hash_val = __hash_text(str(user_id))
val = "{}:{}".format(user_id, hash_val)
response.set_cookie(auth_cookie_name, val)
response.set_cookie(auth_cookie_name, val, secure=False, httponly=True, samesite='Lax')


def __hash_text(text: str) -> str:
Expand All @@ -22,7 +22,7 @@ def __hash_text(text: str) -> str:


def __add_cookie_callback(_, response: Response, name: str, value: str):
response.set_cookie(name, value, max_age=timedelta(days=30))
response.set_cookie(name, value, max_age=timedelta(days=30), secure=False, httponly=True, samesite='Lax')


def get_user_id_via_auth_cookie(request: Request) -> Optional[int]:
Expand Down