Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split trainer cli function into two functions #1197

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

roomrys
Copy link
Collaborator

@roomrys roomrys commented Feb 27, 2023

Description

I split the main training function into two (for easier testing).

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1197 (21436fe) into develop (1c7b314) will decrease coverage by 0.50%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop    #1197      +/-   ##
===========================================
- Coverage    72.32%   71.82%   -0.50%     
===========================================
  Files          132      132              
  Lines        23326    23328       +2     
===========================================
- Hits         16870    16755     -115     
- Misses        6456     6573     +117     
Impacted Files Coverage Δ
sleap/skeleton.py 91.15% <ø> (ø)
sleap/nn/training.py 75.39% <50.00%> (-0.80%) ⬇️
sleap/nn/evals.py 55.65% <0.00%> (-34.79%) ⬇️
sleap/nn/callbacks.py 50.89% <0.00%> (-26.79%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roomrys roomrys marked this pull request as ready for review March 1, 2023 19:46
@roomrys roomrys requested a review from talmo March 1, 2023 19:47
@roomrys
Copy link
Collaborator Author

roomrys commented Mar 1, 2023

Note that the decrease in coverage is because we no longer need to actually run training to test whether the Trainer is created as expected through the CLI. The increased coverage (but also testing slow-down) was added in #1130. This PR removes that extra coverage which we weren't even trying to test/verify in the first place.

@roomrys roomrys merged commit 7abfac7 into develop Mar 2, 2023
@roomrys roomrys deleted the liezl/split-trainer-cli-into-two branch March 2, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant