-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conda builds #1776
Fix conda builds #1776
Conversation
…the matrix and add print statements for testing
…ing the environment in a workflow
WalkthroughThe recent updates focus on enhancing build and test workflows using Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- .conda/meta.yaml (1 hunks)
- .conda_mac/build.sh (1 hunks)
- .conda_mac/condarc.yaml (1 hunks)
- .conda_mac/meta.yaml (3 hunks)
- .github/workflows/build_manual.yml (2 hunks)
- requirements.txt (1 hunks)
Files skipped from review due to trivial changes (5)
- .conda/meta.yaml
- .conda_mac/build.sh
- .conda_mac/condarc.yaml
- .conda_mac/meta.yaml
- requirements.txt
Additional comments not posted (6)
.github/workflows/build_manual.yml (6)
14-15
: Branch trigger updated to includeelizabeth/fix-mac-conda-build
.
86-86
: SavingBUILD_PATH
as aGITHUB_ENV
variable for Ubuntu.
94-94
: SavingBUILD_PATH
as aGITHUB_ENV
variable for Windows.
102-102
: SavingBUILD_PATH
as aGITHUB_ENV
variable for Mac.
104-137
: Testing built conda package for Ubuntu and Windows.
138-170
: Testing built conda package for Mac.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1776 +/- ##
===========================================
+ Coverage 73.30% 74.11% +0.80%
===========================================
Files 134 134
Lines 24087 24462 +375
===========================================
+ Hits 17658 18131 +473
+ Misses 6429 6331 -98 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/build.yml (1 hunks)
- sleap/version.py (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/build.yml
- sleap/version.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/build.yml (1)
87-154
: Ensure consistency in environment setup across OS platforms.Verification successful
Ensure consistency in environment setup across OS platforms.
The environment setup and testing steps for Ubuntu/Windows and Mac are consistent. Both sections follow the same sequence of commands for creating and testing the conda environment with the
sleap
package. The only difference is the channels used in theconda create
command, which is expected due to platform-specific dependencies.
- Ubuntu/Windows uses:
-c file://$BUILD_PATH -c sleap/label/dev -c conda-forge -c nvidia -c anaconda
- Mac uses:
-c file://$BUILD_PATH -c conda-forge -c anaconda
This difference is necessary and does not indicate inconsistency in the overall setup process.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the environment setup and testing steps are consistent across different OS platforms in the workflow file. # Test: Search for inconsistencies in environment setup and testing steps. Expect: Uniform steps across all OS platforms. rg --type yaml $'echo "Creating and testing conda environment with sleap package..."' .github/workflows/build.ymlLength of output: 270
Script:
#!/bin/bash # Extract and compare the environment setup and testing steps for Ubuntu/Windows and Mac in the workflow file. # Extract the Ubuntu/Windows section ubuntu_windows_section=$(sed -n '/# Test built conda package (Ubuntu and Windows)/,/# Test built conda package (Mac)/p' .github/workflows/build.yml) # Extract the Mac section mac_section=$(sed -n '/# Test built conda package (Mac)/,$p' .github/workflows/build.yml) # Output the sections for comparison echo "Ubuntu/Windows Section:" echo "$ubuntu_windows_section" echo echo "Mac Section:" echo "$mac_section"Length of output: 16897
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/build_ci.yml (1 hunks)
- .github/workflows/build_manual.yml (2 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/build_ci.yml
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build_manual.yml
…etup-python action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/build_ci.yml (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/build_ci.yml
Description
.conda/meta.yml
since conda solver is taking too long.build_manual.yml
andbuild.yml
since we are able to use the libmamba conda-solver in the miniconda set-up.BUILD_PATH
is saved as aGITHUB_ENV
so it can be used in the next stage.BUILD_PATH
is used to create an environment with the conda package for each OS.conda-forge::python >=3.9.0, <3.10.0
.qudida
andalubmentations
are now longer needed in the mac build.sh since they are installed using conda-forge.Types of changes
Does this address any currently open issues?
build_manual.yaml
by creating a conda environment with the built conda packages, it became clear that the mac build was failing for a different reason then taking forever to resolve with a conda solver.Outside contributors checklist
Thank you for contributing to SLEAP!
❤️