Do not always color skeletons table black

[roomrys]

Description

Previously, our logic for coloring the items in the skeletons table had morphed unnoticed overtime from the initial feature (Apply node/edge color to skeleton tables.) and eventually resulted in it always being colored black.

In this PR, we simply remove the SkeletonEdgesTableModel.get_item_color and SkeletonNodesTableModel.get_item_color methods which defaults to the Qt coloring (that is used for our other tables).

Types of changes

• Bugfix
• New feature
• Refactor / Code style update (no logical changes)
• Build / CI changes
• Documentation Update
• Other (explain)

Does this address any currently open issues?

• Improve dark mode support #1865

Outside contributors checklist

• Review the guidelines for contributing to this repository
• Read and sign the CLA and add yourself to the authors list
• Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
• Add tests that prove your fix is effective or that your feature works
• Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

Summary by CodeRabbit

• Bug Fixes

  • Removed outdated methods for item color retrieval, improving overall application stability and reducing potential errors related to color management.

• Refactor

  • Streamlined color handling logic by eliminating redundant methods, paving the way for future enhancements in item visualization.

[coderabbitai]

Walkthrough

The pull request removes the get_item_color method from two classes, SkeletonEdgesTableModel and GenericTableModel, in the sleap/gui/dataviews.py file. This method was responsible for retrieving item colors based on keys and skeleton contexts. The removal indicates a potential change in how item colors are managed within the application, which may affect components relying on these methods.

Changes

Files	Change Summary
sleap/gui/dataviews.py	Removed get_item_color method from SkeletonEdgesTableModel and GenericTableModel.

Possibly related PRs

• (4c -> 4) Add color by InstanceGroup option #1760: This PR modifies the get_item_color method in the ColorManager class to handle colors for instance groups, which is directly related to the removal of the get_item_color methods in the main PR.

Suggested labels

MultiView Stack

Poem

In the code where colors used to play,
A rabbit hops, and they’ve gone away.
With a flick of a paw, the methods are gone,
New paths to explore, a fresh dawn.
Let’s dance in the fields of code so bright,
For change brings new joy, a delightful sight! 🐇✨

Tip

New features

Walkthrough comment now includes:

• Possibly related PRs: A list of potentially related PRs to help you recall past context.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

• Please share any feedback in the discussion post on our Discord.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (7ed1229) to head (e20d11c).
Report is 50 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1952      +/-   ##
===========================================
+ Coverage    73.30%   75.36%   +2.05%     
===========================================
  Files          134      133       -1     
  Lines        24087    24467     +380     
===========================================
+ Hits         17658    18439     +781     
+ Misses        6429     6028     -401     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 91d6c96 and e20d11c.

Files selected for processing (1)

• sleap/gui/dataviews.py (2 hunks)

Additional comments not posted (2)

sleap/gui/dataviews.py (2)

Line range hint 1-1: Verify the impact of removing get_item_color from SkeletonEdgesTableModel.

The get_item_color method has been completely removed from the SkeletonEdgesTableModel class. This method was responsible for retrieving the color of an item based on its source and destination attributes using the color_manager.

The removal of this method indicates a potential change in how item colors are managed or displayed within the application. It's crucial to verify that this removal does not lead to any unintended consequences or issues in the functionality related to item color retrieval.

To verify the impact of this change, please run the following script:

Please provide the output of running this script and confirm if there are any concerns regarding the removal of get_item_color from SkeletonEdgesTableModel. If there are no issues found, please explicitly mention that in your response.

---

Line range hint 1-1: Verify the impact of removing get_item_color from SkeletonNodesTableModel.

The get_item_color method has been completely removed from the SkeletonNodesTableModel class. This method was responsible for retrieving the color of an item based on its key attribute using the color_manager.

The removal of this method indicates a potential change in how item colors are managed or displayed within the application. It's crucial to verify that this removal does not lead to any unintended consequences or issues in the functionality related to item color retrieval.

To verify the impact of this change, please run the following script:

Please provide the output of running this script and confirm if there are any concerns regarding the removal of get_item_color from SkeletonNodesTableModel. If there are no issues found, please explicitly mention that in your response.