Stop using “brackets” to mean “braces” #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, in my part of the world, brackets usually refer to parentheses (or round brackets), curly brackets refer to braces, and square brackets are, well, square. |
knausj85
approved these changes
Jan 6, 2024
nriley
reviewed
Jan 13, 2024
There was a problem hiding this comment.
Thanks for doing this — I made many of these changes years ago in my own repo.
I think adding "curly bracket" everywhere we use "brace" would make sense too (see @auscompgeek's comment). That should cover all the common names!
…onhub-community into inherently-square-brackets
|
Updated with @nriley's suggestions. There are "squares" and "braces" in text_navigation.py, in |
|
I think it's OK to leave text_navigation alone as at least it doesn't misuse "brackets" — I don't think it gets a lot of use (personally I keep forgetting it exists / to use it!). In an ideal world we could harmonize everything with Cursorless… |
sisi-sh
added a commit
to sisi-sh/sisi_talon
that referenced
this pull request
Apr 1, 2024
* 'main' of github.com:talonhub/community: (73 commits) add lowercased firefox-esr to firefox.py (talonhub#1410) configurable number prefix without mouse grid (talonhub#1342) Update app.exe matching to work with both public and beta Talon (talonhub#1385) Add comment line to javascript (talonhub#1387) Add detail to documentation (talonhub#1380) Switch to black pre-commit mirror (talonhub#1378) Update app_name_overrides.windows.csv to use Windows Terminal instead of iTerm2 (talonhub#1379) [pre-commit.ci] pre-commit autoupdate (talonhub#1376) coalesce some list updates (talonhub#1348) Remove unused setting from c code language (talonhub#1368) mouse: adding synonyms for starting left drag. (talonhub#1356) Adds commands to focus on the last application (talonhub#1336) Stop using “brackets” to mean “braces” (talonhub#1344) Update settings descriptions (talonhub#1371) Revert changes to `user.mouse_enable_pop_click` (talonhub#1370) Fix typo in `mouse.py` variable name (talonhub#1372) Convert boolean settings to boolean (talonhub#1360) Add ruby op-or-equals command (talonhub#1347) added app name Mate-terminal (fork of Gnome-terminal) (talonhub#1367) added app name Caja (fork of Nautilus) (talonhub#1366) ...
emragins
pushed a commit
to emragins/talon-community
that referenced
this pull request
May 28, 2024
I’ve been tripped up repeatedly by how the vocabulary gives me `{}` when
I say “brackets”. In my part of the world, at least, “brackets” are `[]`
and “braces” are `{}`. “Square brackets” is a belt-and-suspenders
redundancy, like “ATM machine” or “PIN number”.
For what it's worth, aegis [agreed with me in
Slack](https://talonvoice.slack.com/archives/C7ERD5Q5T/p1703888321381209)
that there ought to be only one way to refer to these sorts of things.
I looked through [old
Issues](https://github.com/talonhub/community/issues?q=is%3Aissue+bracket)
and [old
PRs](https://github.com/talonhub/community/pulls?q=is%3Apr+bracket) and
nothing explicitly said “we choose to mean that ‘brackets’ are either
curly or square depending on whether you say ‘square’ first.”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’ve been tripped up repeatedly by how the vocabulary gives me
{}when I say “brackets”. In my part of the world, at least, “brackets” are[]and “braces” are{}. “Square brackets” is a belt-and-suspenders redundancy, like “ATM machine” or “PIN number”.For what it's worth, aegis agreed with me in Slack that there ought to be only one way to refer to these sorts of things.
I looked through old Issues and old PRs and nothing explicitly said “we choose to mean that ‘brackets’ are either curly or square depending on whether you say ‘square’ first.”