coalesce some list updates #1348
Conversation
There was a problem hiding this comment.
I don't think this is right. ctx is local to the outer for loop; defined in its guard
|
If that's the case, I'm going to strongly recommend you remove the dir setting and use a directory relative to the code, so the contexts can be populated before Talon is ready. I'll also recommend in the fs.watch only updating the file that changed (if you're not doing that). This code path is currently triggering a lot of work inside Talon. |
AndreasArvidsson
dismissed
their stale review
Missed the change in indentation
|
I'm inclined to merge this after fixing the indentation and open an issue until someone has the bandwidth to address lunixboch's broader suggestion re: removing snippets setting. This is at least an improvement in an interim. |
We implemented this feature in response to a user request (#1306), but if untenable, I guess we could roll it back?
Makes sense; prob for a follow-up PR though. Filed #1373 to track |
correct indentation
for more information, see https://pre-commit.ci
* 'main' of github.com:talonhub/community: (73 commits) add lowercased firefox-esr to firefox.py (talonhub#1410) configurable number prefix without mouse grid (talonhub#1342) Update app.exe matching to work with both public and beta Talon (talonhub#1385) Add comment line to javascript (talonhub#1387) Add detail to documentation (talonhub#1380) Switch to black pre-commit mirror (talonhub#1378) Update app_name_overrides.windows.csv to use Windows Terminal instead of iTerm2 (talonhub#1379) [pre-commit.ci] pre-commit autoupdate (talonhub#1376) coalesce some list updates (talonhub#1348) Remove unused setting from c code language (talonhub#1368) mouse: adding synonyms for starting left drag. (talonhub#1356) Adds commands to focus on the last application (talonhub#1336) Stop using “brackets” to mean “braces” (talonhub#1344) Update settings descriptions (talonhub#1371) Revert changes to `user.mouse_enable_pop_click` (talonhub#1370) Fix typo in `mouse.py` variable name (talonhub#1372) Convert boolean settings to boolean (talonhub#1360) Add ruby op-or-equals command (talonhub#1347) added app name Mate-terminal (fork of Gnome-terminal) (talonhub#1367) added app name Caja (fork of Nautilus) (talonhub#1366) ...
Snippets and file manager list updates trigger more context refreshes than necessary. Due to an indentation issue, snippets are currently triggering 101 full context re-evaluations every time snippets load/reload (linear to number of snippets). --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jeff Knaus <knaus.jeff@gmail.com>
Snippets and file manager list updates trigger more context refreshes than necessary. Due to an indentation issue, snippets are currently triggering 101 full context re-evaluations every time snippets load/reload (linear to number of snippets).