Update app.exe matching to work with both public and beta Talon #1385
Conversation
nriley
commented
Feb 10, 2024
nriley
commented
- Update mixed-case app.exe: matchers to work with public and beta Talon.
- Update app switcher to work with public and beta Talon.
To fix talonvoice/talon#355, beta Talon uses lowercase for app.exe. Any app.exe matchers that use capital letters won't work on beta Talon, so temporarily change them to case-insensitive regular expression matchers until the next public release of Talon matches the beta's behavior.
To fix talonvoice/talon#355, beta Talon uses lowercase for app.exe. As the app name overrides CSV allows you to override by app.exe on Windows, any overrides (including some defaults from community) will won't work on beta Talon, so lowercase everything. Also updates "running list" to be a more readable and implements the "todo" so overrides actually override spoken forms for an application.
|
I've not got Windows at home so this specific set of changes aren't well tested, but wanted to get it out there since these changes will affect Talon beta users. Will test more on Monday if nobody else does over the weekend! |
Don't clear app name overrides when other files in its directory change. Also update file name matching for Talon returning Windows file paths as lowercase.
for more information, see https://pre-commit.ci
|
Been using this all week and made a couple more changes as well as fixing a bug I was surprised was there so long (the override list was getting cleared entirely!) Also since I had been using "running list" more I made some changes to allow you to exclude applications entirely from it to make the list more manageable (you can see my list here: https://github.com/nriley/talon_community/blob/nriley/core/app_switcher/app_name_overrides.windows.csv) |
|
Should we update the copy context commands to do this regex magic? |
Good call, yes! Will do (update: done, see below). |
To fix talonvoice/talon#355, beta Talon uses lowercase for app.exe. Any app.exe matchers that use capital letters will fail on beta Talon, so temporarily generate case-insensitive regular expression matchers. Also use more concise method to extract the last component of a path.
|
Definitely. We should also update create app context: We should probably even unify the implementation of these two |
To fix talonvoice/talon#355, beta Talon uses lowercase for app.exe. Any app.exe matchers that use capital letters will fail on beta Talon, so temporarily generate case-insensitive regular expression matchers. Also use more concise methods to extract the last component of a path and strip trailing ".exe".
Done.
Agreed, although would prefer to do another time. They generate Windows app matches differently — create_app_context just matches app.exe and talon copy context also matches app.name. |
…nhub#1385) - Update mixed-case app.exe: matchers to work with public and beta Talon. - Update app switcher to work with public and beta Talon. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* 'main' of github.com:talonhub/community: (73 commits) add lowercased firefox-esr to firefox.py (talonhub#1410) configurable number prefix without mouse grid (talonhub#1342) Update app.exe matching to work with both public and beta Talon (talonhub#1385) Add comment line to javascript (talonhub#1387) Add detail to documentation (talonhub#1380) Switch to black pre-commit mirror (talonhub#1378) Update app_name_overrides.windows.csv to use Windows Terminal instead of iTerm2 (talonhub#1379) [pre-commit.ci] pre-commit autoupdate (talonhub#1376) coalesce some list updates (talonhub#1348) Remove unused setting from c code language (talonhub#1368) mouse: adding synonyms for starting left drag. (talonhub#1356) Adds commands to focus on the last application (talonhub#1336) Stop using “brackets” to mean “braces” (talonhub#1344) Update settings descriptions (talonhub#1371) Revert changes to `user.mouse_enable_pop_click` (talonhub#1370) Fix typo in `mouse.py` variable name (talonhub#1372) Convert boolean settings to boolean (talonhub#1360) Add ruby op-or-equals command (talonhub#1347) added app name Mate-terminal (fork of Gnome-terminal) (talonhub#1367) added app name Caja (fork of Nautilus) (talonhub#1366) ...
…nhub#1385) - Update mixed-case app.exe: matchers to work with public and beta Talon. - Update app switcher to work with public and beta Talon. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
