Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused setting from c code language #1368

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

brief
Copy link
Contributor

@brief brief commented Jan 21, 2024

Removes a dead setting from the c code language.

@fidgetingbits
Copy link
Collaborator

I'm ok with removing this, but I guess I should note that I actually have the functionality related to that setting in my branch, so if there is interest I could send a PR to include the missing bits instead.

https://github.com/fidgetingbits/fidgetingbits-talon/blob/master/lang/c/c.py

@nriley
Copy link
Collaborator

nriley commented Jan 27, 2024

@fidgetingbits Would seem useful to put the functionality in. Would you rather we merge this in the meantime?

@fidgetingbits
Copy link
Collaborator

@fidgetingbits Would seem useful to put the functionality in. Would you rather we merge this in the meantime?

ya that makes sense, won't get to it right away

@fidgetingbits fidgetingbits merged commit ebb7dfd into talonhub:main Jan 28, 2024
2 checks passed
@brief brief deleted the remove-unused-settings branch January 28, 2024 03:07
sisi-sh added a commit to sisi-sh/sisi_talon that referenced this pull request Apr 1, 2024
* 'main' of github.com:talonhub/community: (73 commits)
  add lowercased firefox-esr to firefox.py (talonhub#1410)
  configurable number prefix without mouse grid (talonhub#1342)
  Update app.exe matching to work with both public and beta Talon (talonhub#1385)
  Add comment line to javascript (talonhub#1387)
  Add detail to documentation (talonhub#1380)
  Switch to black pre-commit mirror (talonhub#1378)
  Update app_name_overrides.windows.csv to use Windows Terminal instead of iTerm2 (talonhub#1379)
  [pre-commit.ci] pre-commit autoupdate (talonhub#1376)
  coalesce some list updates (talonhub#1348)
  Remove unused setting from c code language (talonhub#1368)
  mouse: adding synonyms for starting left drag. (talonhub#1356)
  Adds commands to focus on the last application (talonhub#1336)
  Stop using “brackets” to mean “braces” (talonhub#1344)
  Update settings descriptions (talonhub#1371)
  Revert changes to `user.mouse_enable_pop_click` (talonhub#1370)
  Fix typo in `mouse.py` variable name (talonhub#1372)
  Convert boolean settings to boolean (talonhub#1360)
  Add ruby op-or-equals command (talonhub#1347)
  added app name Mate-terminal (fork of Gnome-terminal) (talonhub#1367)
  added app name Caja (fork of Nautilus) (talonhub#1366)
  ...
emragins pushed a commit to emragins/talon-community that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants