Convert boolean settings to boolean #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, thanks. I think we should go ahead and convert to boolean literals while we're here |
|
@knausj85 done. The only setting I haven't converted is in c.talon since I'm not sure it actually does anything: points to a single reference in c.py. I'll convert if we want to keep it. Can submit a separate pull request to remove it otherwise. |
knausj85
approved these changes
Jan 21, 2024
|
Yeah, that looks to be a dead setting. I'd say remove it in a separate pull request if you don't mind |
brief
added a commit
to brief/community
that referenced
this pull request
Jan 22, 2024
Fixes a typo in talonhub#1360
fidgetingbits
pushed a commit
that referenced
this pull request
Jan 28, 2024
Removes a [dead setting](#1360 (comment)) from the c code language.
MartinRykfors
pushed a commit
to MartinRykfors/knausj_talon
that referenced
this pull request
Jan 31, 2024
Turn boolean settings in `mouse.py` and `file_manager.py` into proper booleans. For now, I've held off on converting the corresponding `.talon` settings to boolean literals per talonhub#1296, but happy to do that too if there are no concerns.
sisi-sh
added a commit
to sisi-sh/sisi_talon
that referenced
this pull request
Apr 1, 2024
* 'main' of github.com:talonhub/community: (73 commits) add lowercased firefox-esr to firefox.py (talonhub#1410) configurable number prefix without mouse grid (talonhub#1342) Update app.exe matching to work with both public and beta Talon (talonhub#1385) Add comment line to javascript (talonhub#1387) Add detail to documentation (talonhub#1380) Switch to black pre-commit mirror (talonhub#1378) Update app_name_overrides.windows.csv to use Windows Terminal instead of iTerm2 (talonhub#1379) [pre-commit.ci] pre-commit autoupdate (talonhub#1376) coalesce some list updates (talonhub#1348) Remove unused setting from c code language (talonhub#1368) mouse: adding synonyms for starting left drag. (talonhub#1356) Adds commands to focus on the last application (talonhub#1336) Stop using “brackets” to mean “braces” (talonhub#1344) Update settings descriptions (talonhub#1371) Revert changes to `user.mouse_enable_pop_click` (talonhub#1370) Fix typo in `mouse.py` variable name (talonhub#1372) Convert boolean settings to boolean (talonhub#1360) Add ruby op-or-equals command (talonhub#1347) added app name Mate-terminal (fork of Gnome-terminal) (talonhub#1367) added app name Caja (fork of Nautilus) (talonhub#1366) ...
code-n-cool
added a commit
to code-n-cool/social-community
that referenced
this pull request
May 10, 2024
Removes a [dead setting](talonhub/community#1360 (comment)) from the c code language.
emragins
pushed a commit
to emragins/talon-community
that referenced
this pull request
May 28, 2024
Turn boolean settings in `mouse.py` and `file_manager.py` into proper booleans. For now, I've held off on converting the corresponding `.talon` settings to boolean literals per talonhub#1296, but happy to do that too if there are no concerns.
emragins
pushed a commit
to emragins/talon-community
that referenced
this pull request
May 28, 2024
Removes a [dead setting](talonhub#1360 (comment)) from the c code language.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn boolean settings in
mouse.pyandfile_manager.pyinto proper booleans. For now, I've held off on converting the corresponding.talonsettings to boolean literals per #1296, but happy to do that too if there are no concerns.