Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor core generation process #92

Merged
merged 16 commits into from
Jul 25, 2018
Merged

Refactor core generation process #92

merged 16 commits into from
Jul 25, 2018

Conversation

sjoerdtalsma
Copy link
Contributor

See #91 for details

@sjoerdtalsma
Reverse HTML and UML generation
f262924 
First step in refactoring the generation process.
@coveralls
Copy link

coveralls commented Jul 13, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 526

  • 165 of 189 (87.3%) changed or added relevant lines in 16 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.9%) to 90.667%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/nl/talsmasoftware/umldoclet/javadoc/UMLFactory.java 23 24 95.83%
src/main/java/nl/talsmasoftware/umldoclet/uml/Link.java 35 37 94.59%
src/main/java/nl/talsmasoftware/umldoclet/uml/UMLRoot.java 19 21 90.48%
src/main/java/nl/talsmasoftware/umldoclet/uml/Diagram.java 22 25 88.0%
src/main/java/nl/talsmasoftware/umldoclet/uml/Parameters.java 4 8 50.0%
src/main/java/nl/talsmasoftware/umldoclet/UMLDocletException.java 0 6 0.0%
src/main/java/nl/talsmasoftware/umldoclet/UMLDoclet.java 13 19 68.42%
Files with Coverage Reduction New Missed Lines %
src/main/java/nl/talsmasoftware/umldoclet/uml/TypeMember.java 1 78.57%
src/main/java/nl/talsmasoftware/umldoclet/uml/Method.java 1 77.78%
src/main/java/nl/talsmasoftware/umldoclet/uml/TypeName.java 3 66.1%
src/main/java/nl/talsmasoftware/umldoclet/UMLDoclet.java 4 64.44%
Totals Coverage Status
Change from base Build 504: -0.9%
Covered Lines: 1292
Relevant Lines: 1425
💛 - Coveralls

@sjoerdtalsma
Separate puml creation from diagram rendering: step 1, no more diagrams
c43f338
@sjoerdtalsma
Minor change toward refactoring
2bbc5fd
@sjoerdtalsma
More refactoring toward separated UML and Diagram rendering
7b4c5f9
@sjoerdtalsma
Refactor 'diagram' name out of uml package
723aa0a
@sjoerdtalsma
Merge remote-tracking branch 'remotes/origin/develop' into refactor-core
4ab8051
@sjoerdtalsma
Move image file name resolution to new Diagram class
3fc9a83
@sjoerdtalsma
Rename UMLFile to UMLRoot (file is technically no longer necessary)
87c70b8
@sjoerdtalsma
Generate images again
c375835 
Links are still broken in case imageDir is used
@sjoerdtalsma
Introduce -createPumlFiles option to create .puml files
44cd8a5 
These are technically no longer needed and won't be created by default
Also removed 'plantuml' package that was refactored to the Diagram class
@sjoerdtalsma
Remove overengineered NamespaceAware interface
489eb91
@sjoerdtalsma
Move Diagram to uml package
1127b36
@sjoerdtalsma
Introduce Link class in uml package
f369734
@sjoerdtalsma
Fix links to included classes (also relative from 'images' directory)
89f470c
@sjoerdtalsma
Refactoring: Simplify UMLPart getChildren
1d18059
@sjoerdtalsma
Remove some obsolete code that wasn't used anymore
42192ef 
Also add a few simple unit tests
@sjoerdtalsma sjoerdtalsma merged commit 90d5875 into develop Jul 25, 2018
@sjoerdtalsma sjoerdtalsma deleted the refactor-core branch July 25, 2018 10:03
This was referenced Jul 25, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjoerdtalsma @coveralls