Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Firefox. #27

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Port to Firefox. #27

merged 2 commits into from
Jul 31, 2018

Conversation

omasanori
Copy link
Contributor

@omasanori omasanori commented Jul 22, 2018

I love illustration and Firefox, so I ported Ku-nya to Firefox!

Thanks to the WebExtensions API, real porting effort is almost nothing: ~3 min for searching how to make an extension and ~1 min for validating it on addons.mozilla.org (AMO).

What I actually did is to remove optional and unused background field in manifest.json since Firefox requires page field in it. I confirmed that the modified code runs on Firefox 61.0.1 and Chrome 67.0.3396.99 with Windows 10 x64.

It would be great if you could publish it to AMO. Otherwise, I will help.

Packaging:

$ yarn build
$ cd release
$ find . | xargs zip ../Ku-nya.zip

Screenshot:
Ku-nya on Firefox

omasanori and others added 2 commits July 22, 2018 15:01
Signed-off-by: Masanori Ogino <masanori.ogino@gmail.com>
@tamanobi
Copy link
Owner

I tested on Firefox 61.0.1(macOS). Goodjob.

@tamanobi tamanobi merged commit 5dc4cf7 into tamanobi:master Jul 31, 2018
@tamanobi
Copy link
Owner

I submitted to AMO.

@tamanobi
Copy link
Owner

@omasanori I published to AMO(https://addons.mozilla.org/ja/firefox/addon/ku-nya/). Thanks your PR and message.

@omasanori
Copy link
Contributor Author

Thank you for your effort!

@omasanori
Copy link
Contributor Author

@tamanobi Just to confirm, do you select supported platforms as Linux, Mac OS and Windows instead of All platforms?
On AMO "all platforms" means "runs on both desktop Firefox and Android Firefox." I confirmed that Ku-nya does not override new tab page on Firefox on Android, so I am anxious if it is displayed on Firefox on Android add-ons portal too due to "all platforms" checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants