This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Get exception message from event callback #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourtemb
reviewed
Feb 1, 2018
There was a problem hiding this comment.
Great initiative! Thank you very much!
Let's take this opportunity to fix this error which was there before:
Le's replace all the strings containing Tango::ZmqEventConsumer::push_structured_event() with Tango::ZmqEventConsumer::push_zmq_event() in zmqeventconsumer.cpp.
Catching known exceptions like DevFailed or std::exception allows us to print more information regarding the caught exception.
t-b
force-pushed
the
get-exception-message-from-event-callback
branch
from
bc17493 to
53f5d08
Compare
|
@bourtemb Good point. Done. |
bourtemb
approved these changes
Feb 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.