This repository was archived by the owner on Jul 8, 2022. It is now read-only.
Ignore ENOENT during zmq_disconnect call (fixes #514) #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxx_stateless_subscription seems to be a good test to highlight this problem with ZMQ >= 4.2.3 |
bourtemb
approved these changes
Jan 28, 2019
bourtemb
added a commit
to bourtemb/cppTango
that referenced
this pull request
Feb 4, 2019
bourtemb
added a commit
to bourtemb/cppTango
that referenced
this pull request
Mar 1, 2019
bourtemb
added a commit
to bourtemb/cppTango
that referenced
this pull request
Mar 1, 2019
bourtemb
added a commit
to bourtemb/cppTango
that referenced
this pull request
Mar 26, 2019
bourtemb
added a commit
to bourtemb/cppTango
that referenced
this pull request
Mar 28, 2019
Ingvord
pushed a commit
that referenced
this pull request
Mar 29, 2019
* Added CHANGELOG.md This file is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). List changes since cppTango 9.2.5. Changes with potential compatibility issues are documented as suggested in #509 and are in bold. * Add links to issues and PRs in CHANGELOG.md * Update CHANGELOG.md with references to #508,#516,#518,#520,#521,#522,#523,#529,#531,#533,#537 * Update CHANGELOG.md with #517 * Update CHANGELOG.md. Add link for issue 395 * Moved 2 items from Fixed to Changed section Added a warning about the event subscription change sleep reduction * First version of the release notes for cppTango 9.3.3 Rename RELEASE_NOTES in RELEASE_NOTES.md. The previous RELEASE_NOTES content has been moved to CHANGELOG.md file. * Added reference to cppTango#539 Preparation for cppTango 9.3.3 release * Update CHANGELOG and RELEASE_NOTES with #541 and #542 * Reword one item in CHANGELOG.md and RELEASE_NOTES.md * Update CHANGELOG.md with #544, #546 and #549 * Add reference to #532 Add 9.3.3 release date * Add 9.3.3 release date
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in ZMQ 4.2.3 breaks one of Tango tests (
cxx_stateless_subscription, see #514 for details).Since zeromq/libzmq@edb4ca1, peer disconnection triggers
zmq_disconnecton a zmq socket. Furtherzmq_disconnectcalls for such socket and endpoint will fail with errno set toENOENT. This patch silently ignores such failure.I'm not adding any new testcases. I don't think it is possible to have a reliable reproduction with ZMQ older than v4.2.3.