Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependences for 1.11.1 version #315

Closed
wants to merge 1 commit into from

Conversation

theasp
Copy link
Collaborator

@theasp theasp commented Dec 3, 2017

This fixes #314 and #311

@danielcompton
Copy link
Collaborator

This seems reasonable to me, I'll merge in a few days unless @ptaoussanis has any objections.

@ptaoussanis
Copy link
Member

ptaoussanis commented Dec 3, 2017

Thanks Andrew, Daniel- looks good!

Small request: would prefer if we bump the minor (x.y.z) version number for substantial dependency updates (since there's some non-zero potential for unexpected breakage).

(I generally try reserve the .z updates for internal code changes that are strictly, clearly non-breaking).

Will try merge this and cut a new Clojars release later this week 👍

(Also still owe you both an email reply, haven't forgotten- apologies for the delay).

@theasp
Copy link
Collaborator Author

theasp commented Dec 4, 2017

I've updated it to 1.12.0. No worries, glad you aren't dead! :)

@ptaoussanis
Copy link
Member

ptaoussanis commented Dec 10, 2017

Merging manually now, thanks again Andrew!

ptaoussanis pushed a commit that referenced this pull request Dec 10, 2017
@ptaoussanis
Copy link
Member

Merged, and cut v1.12.0 on Clojars 👍

Please note that I removed some whitespace changes, and split the dep bumps and version bump into separate commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Had to remove a dependency to start example project
3 participants