Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column name 'company_type_code' not in table 'assets_maintenance' #10

Closed
henghuiz-zz opened this issue Nov 19, 2018 · 7 comments
Closed

Comments

@henghuiz-zz
Copy link

In train_spider.json, there is one example with a question What is the description of the type of the company who concluded its contracts most recently? and a query SELECT T1.company_name FROM Third_Party_Companies AS T1 JOIN Maintenance_Contracts AS T2 ON T1.company_id = T2.maintenance_contract_company_id JOIN Ref_Company_Types AS T3 ON T1.company_type_code = T3.company_type_code ORDER BY T2.contract_end_date DESC LIMIT 1. But the column name 'company_type_code' not in table 'assets_maintenance'. Please check if there is something wrong in this example. I think the column name should be company_type.

@MottoX
Copy link

MottoX commented Nov 28, 2018

This problem causes an exception when using parse_raw_json.py to generate new json file. From my side, the corresponding database assets_maintenance lacks a table named Ref_Company_Types.

@taoyds
Copy link
Owner

taoyds commented Dec 6, 2018

Hi,

We might accidentally delete company_type_code. I will double check this example and update them in the later version. Thanks!

Best,
Tao

@taoyds taoyds closed this as completed Dec 6, 2018
@tin-chata
Copy link

Hi there,

Did you fix this issue? It seems that the current dataset lacks of ref_company_types table and and company_type_code column (in the Third_Party_Companies table) too.

Thanks

@chenyangh
Copy link

It seems that this issue is still not fixed.

@YonghyunRyu
Copy link

This issue still exists. There is a KeyError: ref_company_types.

@WaNePr
Copy link

WaNePr commented Feb 13, 2020

This issue still exists. and causes the output vocabulary when running run.py includes vocab = [..., company_type_code, ref_company_types,...].

@BoCiFOM
Copy link

BoCiFOM commented Jul 10, 2023

The issue still exists. Any fixes for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants