Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.comment() = fail exit code #92

Closed
timoxley opened this issue Jun 25, 2014 · 5 comments
Closed

t.comment() = fail exit code #92

timoxley opened this issue Jun 25, 2014 · 5 comments

Comments

@timoxley
Copy link

Is this correct behaviour?

Including any test comments seems to fail a suite.

// test.js
var test = require('tape')

test('comment test', function(t) {
  t.comment('this is a comment')
  t.ok(true)
  t.end()
})
> tape test.js
TAP version 13
# comment test
# this is a comment
ok 1 (unnamed assert)

1..1
# tests 1
# pass  1

# ok


> echo $?
1
@ghost
Copy link

ghost commented Jun 25, 2014

Nope! That should pass. Bug.

@tmcw
Copy link
Contributor

tmcw commented Jul 22, 2014

👍 should be closed by a22fdd1

@davidtheclark
Copy link
Contributor

I'm still having this problem. Addition of a single comment is causing exit code 1 despite all tests passing; remove the comment and everything's fine.

@geraintwhite
Copy link

This is still a bug in v4.0.1

@soundyogi
Copy link

+1
getting exit code 1

@Raynos Raynos closed this as completed in 8d04af4 Aug 3, 2015
Raynos added a commit that referenced this issue Aug 3, 2015
Comments should not make exit code incorrect. Fixes #92
jakelarkn pushed a commit to jakelarkn/tape that referenced this issue Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants