Comments should not make exit code incorrect. Fixes #92 #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this gets merged in, it should probably also be backported on top of v3.0.3, v3.1.0, v3.2.0, v3.3.0, v3.4.0, v3.5.1, and v3.6.0 - and all of them bumped with a patch release, before publishing this change as v4.0.2. @substack / @Raynos, sound ok? |
|
back porting is amount of effort. Let's get it into master and cut a new patch. |
Raynos
added a commit
that referenced
this pull request
Aug 3, 2015
Comments should not make exit code incorrect. Fixes #92
|
Published 4.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #94 wasn't merged in, so creating a new PR