fix: hooking SIGPROF was interfering with profilers see #21 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 10, 2016 08:37
BREAKING CHANGE: signal-exit no longer wires into SIGPROF
| @@ -77,7 +79,7 @@ function listener (code, signal) { | |||
| function run (opt) { | |||
| console.error(opt) | |||
| var shell = process.platform === 'win32' ? null : { shell: '/bin/bash' } | |||
| exec(process.execPath + ' ' + __filename + ' ' + opt, shell, function (err, stdout, stderr) { | |||
| exec(join(process.execPath, ' ', __filename, ' ' + opt), shell, function (err, stdout, stderr) { | |||
There was a problem hiding this comment.
This is a weird use of path.join. Won't that result in something like /path/to/node/ with a slash at the end?
There was a problem hiding this comment.
100% agree this is a weird new standard nit that I was working around -- if it sees something that looks like a path being execed, it yells at you until you use path.resolve or path.join.
There was a problem hiding this comment.
That sounds like a bug in standard. Especially since you can still throw spaces in there anyway.
Would it be ok with you doing exec(path.resolve(process.execPath) + ' ' + __filename + ' ' + opt)? Ie, just resolve the execPath, not the whole command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: signal-exit no longer wires into SIGPROF
Stop wiring into SIGPROF, this was causing issues discussed in #21 and npm/npmlog#40