fix: serialize decimals as quoted strings in JSON output #2
Conversation
arrow-json/src/writer/encoder.rs
Outdated
| let options = FormatOptions::new().with_display_error(true); | ||
| let formatter = ArrayFormatter::try_new(array, &options)?; | ||
| (Box::new(RawArrayFormatter(formatter)) as _, array.nulls().cloned()) | ||
| (Box::new(formatter) as _, array.nulls().cloned()) |
There was a problem hiding this comment.
What about to extend FormatOptions instead? This allows users to choose the format and keeps backward compatibility.
|
Thank you for the patch! We need to fix tests here: Btw, does decimal deserializer properly works with input strings? |
|
I use |
Ok, it seems that deserializer also uses it https://github.com/tarantool/arrow-rs/blob/main/arrow-json/src/reader/decimal_array.rs#L57-L60, so it will be able to deserialize strings as decimals. |
arrow-cast/src/display.rs
Outdated
| duration_format: DurationFormat, | ||
| /// If set to `true`, decimal values will be formatted as strings instead of numbers | ||
| /// This is useful for JSON output to preserve precision | ||
| decimal_as_string: bool, |
There was a problem hiding this comment.
Does it make sense to change it to enum of formats instead as it's done for others?
There was a problem hiding this comment.
Good idea, I refactored it to use an enum.
Co-authored-by: Artem Novikov <33791946+novartole@users.noreply.github.com>
3 participants
For correct serialization of decimal types into JSON we want them to be serialized as strings instead of numbers so they don't loose precision.