Skip to content

Conversation

DifferentialOrange
Copy link
Member

We cannot guarantee that cached schema is always the old one since net.box may reload the schema, see [1] for example of fail.

  1. https://github.com/tarantool/crud/actions/runs/6531939885/job/17734151700
  • Tests

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/fix-flaky-schema branch from f648874 to 37dbcba Compare October 16, 2023 12:26
@DifferentialOrange DifferentialOrange marked this pull request as ready for review October 16, 2023 12:53
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add a comment to the cached option to clarify that the schema is not always a last/previous one.

We cannot guarantee that cached schema is always the old one since
net.box may reload the schema, see [1] for example of fail.

1. https://github.com/tarantool/crud/actions/runs/6531939885/job/17734151700
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/fix-flaky-schema branch from 37dbcba to febeba6 Compare October 16, 2023 14:07
@DifferentialOrange DifferentialOrange merged commit ab9aad4 into master Oct 16, 2023
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/fix-flaky-schema branch October 16, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants