Describe datetime data and index types #3036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
branch-gh-2509-datetime-storage
github-actions
bot
temporarily deployed
to
branch-gh-2509-datetime-storage
github-actions
bot
temporarily deployed
to
branch-gh-2509-datetime-storage
github-actions
bot
temporarily deployed
to
branch-gh-2509-datetime-storage
tsafin
suggested changes
Jul 19, 2022
| +-------------------+-------------------------+--------------------------------+------------------------------+ | ||
| | scalar | integer | "`number`_" | ``12345`` | | ||
| +-------------------+-------------------------+--------------------------------+------------------------------+ | ||
| | scalar | float 64 (double) | "`number`_" | ``1.2345`` | |
There was a problem hiding this comment.
I do see it's kind of offtopic for the datetime discussion, but still is bothering me: why there are 2 rows for double literals? (LuaJIT ffi cdata and standard Lua number). What we wanted to highlight here? (That we could, depending on value, may end up using either number or extended LuaJIT type? But similarly we would have for integer values, but there are no duplication.)
I'me very much confused here...
There was a problem hiding this comment.
Thanks for noticing that! Tracked in #3040.
* Remove API usage example * Clarify the status of c-dt library
github-actions
bot
temporarily deployed
to
branch-gh-2509-datetime-storage
tsafin
approved these changes
Jul 19, 2022
github-actions
bot
temporarily deployed
to
branch-gh-2509-datetime-storage
patiencedaur
force-pushed
the
gh-2509-datetime-storage
branch
from
be6a300 to
91fc9c5
Compare
github-actions
bot
temporarily deployed
to
branch-gh-2509-datetime-storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2509