Handle OOM #103
Merged
Handle OOM #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds xmalloc, xcalloc, xrealloc helper functions. Each of them calls the corresponding memory allocation function and exits with error if it fails. Handling malloc/mmap failures doesn't make much sense, because modern OSs have quite lenient memory overcommit policies. If an application tries to use more memory than there's available on the host, the OS will do swapping and if that doesn't help, it will kill the application. That's it. No graceful termination. No malloc/mmap failure. Just SIGKILL. Nevertheless, we diligently strive to bail out gracefully in case malloc returns NULL even though all the code written for handling those failures is never executed (see the previous paragraph) hence is untested and likely to have numerous bugs lurking in it. So, let's just panic on malloc failure. Part of #3
olegrok
reviewed
May 24, 2023
olegrok
reviewed
May 24, 2023
olegrok
approved these changes
May 24, 2023
olegrok
reviewed
May 24, 2023
This patch replaces all occurrences of memory related functions with xmalloc, xcalloc and xrealloc, making them to panic, when we fail to allocate memory for them. Closes #3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces all occurrences of memory related functions with
xmalloc, xcalloc and xrealloc, making them to panic, when we fail to
allocate memory for them.
Closes #3