Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support migrations in new replicaset #71

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

psergee
Copy link
Contributor

@psergee psergee commented Mar 26, 2024

Fixed:

Added:

  • API for moving existing migration names storage from cluster config to
    local space.
  • API for getting applied migrations list for the cluster.

If the cleanup process is done for some tests after they have run,
and for others - before, this can lead to a situation where
cleanup is not called at all. To avoid this, make all tests use
the same cleanup scheme: cleanup after each test.
Copy link
Member

@DifferentialOrange DifferentialOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems cool, let's change some minor documentation/test things.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
migrator/init.lua Outdated Show resolved Hide resolved
migrator/init.lua Show resolved Hide resolved
migrator/init.lua Outdated Show resolved Hide resolved
migrator/init.lua Outdated Show resolved Hide resolved
migrator/init.lua Outdated Show resolved Hide resolved
migrator/init.lua Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
migrator/init.lua Outdated Show resolved Hide resolved
@psergee psergee force-pushed the psergee/gh-65-migrations-in-new-replicaset branch 6 times, most recently from bcb4b77 to 629b2a8 Compare March 28, 2024 20:14
@psergee psergee force-pushed the psergee/gh-65-migrations-in-new-replicaset branch from 629b2a8 to 0603584 Compare March 29, 2024 06:16
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Use a space to store the list of applied migrations instead of
the cluster configuration. Each instance independently decides
which migrations to apply. The `up` command returns a table with
all the applied migrations grouped by server alias.

Part of #65
Add new API `move_migrations_state` to move migrations list from
cluster-wide config to local space.

Part of #65
Add new API to get migrations list.

Closes #65
@psergee psergee force-pushed the psergee/gh-65-migrations-in-new-replicaset branch from 0603584 to dd97a09 Compare March 29, 2024 08:55
Copy link
Member

@DifferentialOrange DifferentialOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work!

@psergee psergee merged commit 74e0672 into master Mar 29, 2024
1 check passed
@psergee psergee deleted the psergee/gh-65-migrations-in-new-replicaset branch March 29, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants