-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support migrations in new replicaset #71
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cleanup process is done for some tests after they have run, and for others - before, this can lead to a situation where cleanup is not called at all. To avoid this, make all tests use the same cleanup scheme: cleanup after each test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems cool, let's change some minor documentation/test things.
psergee
force-pushed
the
psergee/gh-65-migrations-in-new-replicaset
branch
6 times, most recently
from
March 28, 2024 20:14
bcb4b77
to
629b2a8
Compare
psergee
force-pushed
the
psergee/gh-65-migrations-in-new-replicaset
branch
from
March 29, 2024 06:16
629b2a8
to
0603584
Compare
Use a space to store the list of applied migrations instead of the cluster configuration. Each instance independently decides which migrations to apply. The `up` command returns a table with all the applied migrations grouped by server alias. Part of #65
Add new API `move_migrations_state` to move migrations list from cluster-wide config to local space. Part of #65
Add new API to get migrations list. Closes #65
psergee
force-pushed
the
psergee/gh-65-migrations-in-new-replicaset
branch
from
March 29, 2024 08:55
0603584
to
dd97a09
Compare
DifferentialOrange
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
Applied migration names are moved from the cluster-wide configuration to
the local space on each node.
Added:
local space.