Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: second take() hangs after disconnect during take() #104

Closed
Totktonada opened this issue Dec 4, 2019 · 2 comments · Fixed by #108
Closed

bug: second take() hangs after disconnect during take() #104

Totktonada opened this issue Dec 4, 2019 · 2 comments · Fixed by #108
Assignees
@LeonidVas
Labels
bug Something isn't working ready for review

Comments

@Totktonada
Copy link
Member

@Mons describes the following case when take() may hang.

Take a task from a connector (say, net.box), disconnect and connect again, try to take this task again. It is stated that the second take will (may?) hang.

It seems that something like this was fixed in xqueue here: moonlibs/xqueue@eb50150

Let's verify it, fix and cover with a test.
@Totktonada Totktonada added the bug Something isn't working label Dec 4, 2019
@LeonidVas LeonidVas self-assigned this Dec 11, 2019
@LeonidVas
Copy link
Contributor

Looks like it has been fixed twice in #103 and tarantool/tarantool#4627

@LeonidVas
Copy link
Contributor

D'oh, I was wrong. This unrelated to #103 bug.

LeonidVas added a commit that referenced this issue Dec 16, 2019
@LeonidVas
Add a check:"Is session exists after wait?"
0a45779 
Fixes" #104
LeonidVas added a commit that referenced this issue Dec 16, 2019
@LeonidVas
Add a check:"Is session exists after wait?"
3a61ebd 
Fixes" #104
LeonidVas added a commit that referenced this issue Dec 16, 2019
@LeonidVas
Add a check:"Is session exists after wait?"
968c2c7 
Fixes" #104
LeonidVas added a commit that referenced this issue Dec 17, 2019
@LeonidVas
Add a check of the session state before take a task
79a544f 
We need to check of a session state before take a task after wait()
because session maybe in disconnecting state and task will be
hang in a take state after the session will be disconnected

Fixes: #104
@LeonidVas LeonidVas mentioned this issue Jan 30, 2020
Merged
LeonidVas added a commit that referenced this issue Feb 3, 2020
@LeonidVas
Add a check of the session state before take a task
4e96760 
We need to check of a session state before take a task after wait()
because session maybe in disconnecting state and task will be
hang in a take state after the session will be disconnected

Fixes #104
@Totktonada Totktonada changed the title bug: second take() hangs after diconnect during take() bug: second take() hangs after disconnect during take() Feb 25, 2020
LeonidVas added a commit that referenced this issue Feb 28, 2020
@LeonidVas
Add a check of the session state before take a task
2344c46 
We need to check of a session state before take a task after wait()
because session maybe in disconnecting state and task will be
hang in a take state after the session will be disconnected

Fixes #104
Totktonada pushed a commit that referenced this issue Feb 28, 2020
@LeonidVas @Totktonada
Add a check of the session state before take a task
5f07d75 
We need to check of a session state before take a task after wait()
because session maybe in disconnecting state and task will be
hang in a take state after the session will be disconnected

Fixes #104
Totktonada pushed a commit that referenced this issue Feb 28, 2020
@LeonidVas @Totktonada
Add a check of the session state before take a task
161ab21 
We need to check of a session state before take a task after wait()
because session maybe in disconnecting state and task will be
hang in a take state after the session will be disconnected

Fixes #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonidVas LeonidVas

Labels
bug Something isn't working ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a check of the session state before take a task tarantool/queue
2 participants
@Totktonada @LeonidVas