Добавить возможность получить количество элементов в очереди

[marrrvin]

Желательно, с возможностью фильтровать по статусу задачи.

[rybakit]

Получить количество элементов можно вызвав queue.statistics().

[marrrvin]

В каком поле? И есть ли документация на формат вывода statistics?

[rybakit]

Общая статистика по всем трубам (tube) из всех пространств (space):

localhost> call queue.statistics()
Call OK, 1 rows affected
[
'space0.my_tube1.ttl.total', '1', 
'space0.my_tube1.put', '4', 
'space0.my_tube1.ttl.ready', '1', 
'space0.my_tube1.tasks.total', '2', 
'space0.my_tube1.tasks.ready', '2', 
'space0.my_tube1.tasks.delayed', '0', 
'space0.my_tube1.tasks.taken', '0', 
'space0.my_tube1.tasks.buried', '0', 
'space0.my_tube1.tasks.done', '0',
'space0.my_tube2.ttl.total', '2', 
...
'spaceN.my_tubeN.ttl.total', '42', 
...
]

Статистика по конкретному пространству (0):

localhost> call queue.statistics('0')
Call OK, 1 rows affected
[
'space0.my_tube1.ttl.total', '1',
'space0.my_tube1.put', '4',
'space0.my_tube1.ttl.ready', '1',
'space0.my_tube1.tasks.total', '2', 
'space0.my_tube1.tasks.ready', '2',
'space0.my_tube1.tasks.delayed', '0',
'space0.my_tube1.tasks.taken', '0', 
'space0.my_tube1.tasks.buried', '0',
'space0.my_tube1.tasks.done', '0'
]

Статистика по конкретному пространству (0) и трубе (my_tube1):

localhost> call queue.statistics('0', 'my_tube1')
Call OK, 1 rows affected
[
'space0.my_tube1.ttl.total', '1', 
'space0.my_tube1.put', '4',
'space0.my_tube1.ttl.ready', '1',
'space0.my_tube1.tasks.total', '2', 
'space0.my_tube1.tasks.ready', '2',
'space0.my_tube1.tasks.delayed', '0',
'space0.my_tube1.tasks.taken', '0', 
'space0.my_tube1.tasks.buried', '0',
'space0.my_tube1.tasks.done', '0'
]

[marrrvin]

Большое спасибо!

1. А что означают поля .ttl.total .ttl.ready?
2. .put это количество тасков, положенных в очередь, с момента запуска сервера?

[kostja]

Please document this (if this is 1.6, otherwise implement & document).

[Sulverus]

for 1.5: https://github.com/tarantool/queue/tree/stable#queuestatistics
for 1.6: implemented in https://github.com/tarantool/queue/tree/gh-9-stats

output format updated:

queue.statistics()
---
- - queue_fifottl_test2:
      tasks:
      - total: 1
      - ready: 1
      - taken: 0
      - buried: 0
      - done: 0
      - delayed: 0
      calls:
      - put: 1
  - queue_fifottl_test:
      tasks:
      - total: 2
      - ready: 1
      - taken: 1
      - buried: 0
      - done: 0
      - delayed: 0
      calls:
      - put: 2
      - take: 1

Awaiting for code review

[rybakit]

To create a queue (tube) a user just specify a tube name, but to get statistics they have to provide a full space name, which I find inconsistent. Also, it exposes implementation details to users.

[Sulverus]

Agree. But what we gonna do in this situation:

queue.create_tube('test', 'fifottl')
queue.create_tube('test', 'fifo')

now we take 2 queues. if get statistics with tube name - return 2 queues data?

[rybakit]

We can update the signature of the statistics() method to something like queue.statistics([tube_type [, tube_name]]). Or pass a full space name to create_tube() instead of a tube name. I prefer the latter, as it's more explicit and flexible. I recall that I had some problems with creating a tube with a long name.

[Sulverus]

I think it's right way to strict this case in create_tube().

[Sulverus]

Max space name length - 32 characters. it specified in tarantool database

[Sulverus]

Done
bf7c969

[Sulverus]

merged