fix fifottl_fiber_iteration error handling #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegrok
reviewed
Sep 19, 2019
PersDep
force-pushed
the
i.kosarev/gh-96-fix-fifottl_fiber
branch
from
6b496cc to
f6e218a
Compare
Totktonada
reviewed
Sep 25, 2019
fifottl_fiber pcalls fifottl_fiber_iteration and then handles result. Returned error code comparison with box.error.READONLY was not done properly. Now it is fixed. Corresponding test case: buried task in dropped queue scenario is added. Closes #96
PersDep
force-pushed
the
i.kosarev/gh-96-fix-fifottl_fiber
branch
from
f6e218a to
e2bd22d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fifottl_fiber pcalls fifottl_fiber_iteration and then handles
result. Returned error code comparison with box.error.READONLY
was not done properly. Now it is fixed.
Closes #96