-
Notifications
You must be signed in to change notification settings - Fork 6
ci: add GitHub Actions CI #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7a50437
to
44e03d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also would be nice to split commit into 2.
Add CI and fix flaky tests.
.github/workflows/tests.yml
Outdated
- name: Install requirements | ||
run: make deps | ||
|
||
- run: make lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add names to steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
.github/workflows/tests.yml
Outdated
|
||
- run: make lint | ||
|
||
- run: make test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add names to steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
.github/workflows/tests.yml
Outdated
|
||
- run: make test | ||
|
||
- run: make coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add names to steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
Closes #53
44e03d4
to
6bd16f8
Compare
Thank you, done. |
The patch adds CI for GitHub Actions and updates flaky tests.
Closes #53
Closes #18