Skip to content

Conversation

oleg-jukovec
Copy link
Contributor

The patch adds CI for GitHub Actions and updates flaky tests.

Closes #53
Closes #18

@oleg-jukovec oleg-jukovec marked this pull request as ready for review May 31, 2023 19:09
@oleg-jukovec oleg-jukovec requested review from AnaNek and GRISHNOV May 31, 2023 19:10
@oleg-jukovec oleg-jukovec requested review from better0fdead and removed request for AnaNek June 8, 2023 09:54
Copy link

@better0fdead better0fdead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also would be nice to split commit into 2.
Add CI and fix flaky tests.

- name: Install requirements
run: make deps

- run: make lint

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add names to steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.


- run: make lint

- run: make test

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add names to steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.


- run: make test

- run: make coverage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add names to steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

The patch adds CI for GitHub Actions and updates flaky tests.

Part of #53
Closes #18
@oleg-jukovec
Copy link
Contributor Author

It also would be nice to split commit into 2. Add CI and fix flaky tests.

Thank you, done.

@oleg-jukovec oleg-jukovec merged commit f9c7772 into master Jun 8, 2023
@oleg-jukovec oleg-jukovec deleted the oleg-jukovec/ci branch June 16, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: testing Add linter check to CI

3 participants