internal: refactoring to prepare for roles #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
changed the title
oleg-jukovec
requested review from
DerekBum
and removed request for
better0fdead
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-68-refactoring
branch
from
da4b966 to
9fe81a9
Compare
Pull Request Test Coverage Report for Build 8539202019Details
💛 - Coveralls |
Calls on vshard replicasets at first glance do not bring additional load, but at the same time they make the code more general and portable to Tarantool 3.0. Part of #68
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-68-refactoring
branch
from
9fe81a9 to
3cea4e9
Compare
DifferentialOrange
approved these changes
Apr 3, 2024
The patch splits a large file `storage.lua` with a Cartridge role for a few smaller files based on their functionality. It will help to create a Tarantool 3.0 role from that blocks instead of copy-paste. Part of #68
The patch splits a large file `api.lua` with a Cartridge role for a few smaller files based on their functionality. It will help to create a Tarantool 3.0 role from that blocks instead of copy-paste. Part of #68
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-68-refactoring
branch
from
3cea4e9 to
960376e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset contains an internal refactoring to implement roles for Tarantool 3.0. It splits roles for Tarantool Cartridge to a logical blocks that could be reused to build Tarantool 3.0 roles.
Part of #68