small: fix incorrect mempool group creation #6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If slab order of first several pools was equal to zero, all these pools added to same group with pools with slab order is equal to one. It's leds to incorrect behavior of `smfree` function, because this function relies on same slab order size of all pools in mempool group. Fix this and add assertion and test to check it. Closes #6659
Korablev77
deleted the
mechanik20051988/gh-6659-fix-segmentation-fault-on-apple-m1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If slab order of first several pools was equal to zero,
all these pools added to same group with pools with slab
order is equal to one. It's leds to incorrect behavior
of
smfreefunction, because this function relies onsame slab order size of all pools in mempool group.
Fix this and add assertion and test to check it.
Closes #6659