Skip to content

Conversation

elhimov
Copy link
Contributor

@elhimov elhimov commented Aug 22, 2025

Make more invormative error when trying to bootstrap non-vshard cluster with tt rs vshard bootstrap command.

I didn't forget about (remove if it is not applicable):

  • Well-written commit messages (see documentation how to write a commit message)
  • Don't forget about TarantoolBot in a commit message (see example)
  • Tests (see documentation for a testing package)
  • Changelog (see documentation for changelog format)

Related issues:

Closes #1201

@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch 6 times, most recently from 6d97e30 to 24bbceb Compare August 25, 2025 21:06
@elhimov elhimov marked this pull request as ready for review August 25, 2025 21:07
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch 3 times, most recently from 43d2a11 to b2e42d8 Compare August 26, 2025 08:23
@elhimov elhimov requested review from oleg-jukovec and dmyger August 26, 2025 08:36
@elhimov elhimov added the full-ci Enables full ci tests label Aug 26, 2025
@elhimov elhimov changed the base branch from master to elhimov/gh-1193-cluster-failover-switch-for-config-storage August 26, 2025 10:20
@elhimov elhimov requested a review from bigbes August 26, 2025 10:20
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from b2e42d8 to 63b3ee4 Compare August 26, 2025 19:53
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch 2 times, most recently from 43c632b to ba0222b Compare August 27, 2025 08:39
@elhimov elhimov force-pushed the elhimov/gh-1193-cluster-failover-switch-for-config-storage branch from ed72381 to 1b52e18 Compare August 27, 2025 09:22
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from ba0222b to 43fa9fe Compare August 27, 2025 09:27
@elhimov elhimov requested a review from dmyger August 27, 2025 12:49
@elhimov elhimov force-pushed the elhimov/gh-1193-cluster-failover-switch-for-config-storage branch from 1b52e18 to 7cf26dc Compare August 28, 2025 17:36
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from 43fa9fe to 9e481ad Compare August 29, 2025 08:04
@elhimov elhimov requested review from patapenka-alexey and removed request for patapenka-alexey August 29, 2025 08:05
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from 9e481ad to a839928 Compare August 29, 2025 18:37
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from a839928 to 3dfada5 Compare August 29, 2025 18:47
Copy link
Contributor

@patapenka-alexey patapenka-alexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch. LGTM.

@elhimov elhimov force-pushed the elhimov/gh-1193-cluster-failover-switch-for-config-storage branch 2 times, most recently from e425467 to 1d1d51b Compare September 1, 2025 06:50
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from 3dfada5 to 9fe3498 Compare September 1, 2025 06:56
@elhimov elhimov force-pushed the elhimov/gh-1193-cluster-failover-switch-for-config-storage branch from 1d1d51b to e31456c Compare September 1, 2025 08:07
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from 9fe3498 to 3384650 Compare September 1, 2025 08:08
@elhimov elhimov force-pushed the elhimov/gh-1193-cluster-failover-switch-for-config-storage branch from e31456c to 1393f4a Compare September 1, 2025 08:18
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from 3384650 to 2a7f5ab Compare September 1, 2025 08:19
@elhimov elhimov force-pushed the elhimov/gh-1193-cluster-failover-switch-for-config-storage branch from 1393f4a to bd60a62 Compare September 1, 2025 09:16
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from 2a7f5ab to b8cb4e6 Compare September 1, 2025 09:17
Base automatically changed from elhimov/gh-1193-cluster-failover-switch-for-config-storage to master September 2, 2025 10:26
Make more informative error when trying to bootstrap non-vshard cluster
with `tt rs vshard bootstrap` command.

Closes #1201

@TarantoolBot document
Title: `tt rs vs bootstrap` more informative error

Make more informative error when trying to launch `tt rs vs bootstrap`
against cluster where no sharing roles configured (for example when
launched against non-vshard cluster).
@elhimov elhimov force-pushed the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch from b8cb4e6 to 8a52002 Compare September 2, 2025 10:31
@dmyger dmyger merged commit 350bf7c into master Sep 2, 2025
32 of 34 checks passed
@dmyger dmyger deleted the elhimov/gh-1201-vshard-bootstrap-for-non-vshard-cluster branch September 2, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-ci Enables full ci tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make more informative error of replicaset vshard bootstrap for non-vshard cluster
4 participants