-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve audio record button #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. A few things I notice, some of which is likely for follow-up:
- I think these tooltip/popups help a lot
- What is the blue checkmark for?
- Is the height change between Recording... and Transcribing... intentional, or part of the animation? There's a lot of movement.
- Can we make the button Red while it is recording, to indicate you can stop it by clicking?
Deploying with Cloudflare Pages
|
That is a grammar check tool installed on my mac, shouldn't appear normally.
That is part of the animation, I am changign the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it ❤️
@tarasglek Are you also okay with merging this? |
This is awesome! Too bad we don't have a way to make it glow while it's recording :) |
@Amnish04 fyi chatcraft has a good suggestion https://chatcraft.org/api/share/tarasglek/swpAJH4JeBzW2nQjE4TGG |
Yeah I also want to have that :) |
Edit: @tarasglek Sorry I was opening the wrong link, will take a look |
@tarasglek I was able to do something like this based on your suggestion. What do you think? |
As requested in #369, I have added a tooltip to the mic button indicating the use to either start or stop recording.
When not Recording:
When not Recording:
Transition:
I tried to find a way to add the animation that @tarasglek suggested, but couldn't find a free and convenient way for that.
https://www.shutterstock.com/video/clip-1071785533-microphone-signal-animated-icon-animation-4k-green
This closes #413