Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing usage of yield in test_utils.py #234

Merged
merged 3 commits into from
May 6, 2015
Merged

Removing usage of yield in test_utils.py #234

merged 3 commits into from
May 6, 2015

Conversation

kaushik94
Copy link
Contributor

Please take a look at #233. Also added a test for species_tuple_to_string. @wkerzendorf please take a look.

@kaushik94
Copy link
Contributor Author

Works perfect now( with the fix also in #232 )

kaushik@ghost:~/Desktop/soc/tardis/tardis/tests$ py.test -q test_util.py
..................
18 passed in 0.69 seconds

@wkerzendorf please take a look.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.01% when pulling d20a187 on kaushik94:tuple_to_string into 1cfef3b on tardis-sn:master.

@kaushik94
Copy link
Contributor Author

@wkerzendorf The test_utils.py doesn't work currently even if we plug in the wrong values, because of the usage of yield and I think this PR solves it. I think we should merge it before we make any major changes to the files. What do you think ?

@wkerzendorf wkerzendorf reopened this May 6, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d20a187 on kaushik94:tuple_to_string into * on tardis-sn:master*.

wkerzendorf added a commit that referenced this pull request May 6, 2015
Removing usage of yield in test_utils.py
@wkerzendorf wkerzendorf merged commit 6d81bbc into tardis-sn:master May 6, 2015
@wkerzendorf
Copy link
Member

@kaushik94 well done!

@kaushik94
Copy link
Contributor Author

Thanks @wkerzendorf .

@kaushik94 kaushik94 deleted the tuple_to_string branch May 6, 2015 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants