Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests added and updated in test_util.py #245

Closed
wants to merge 1 commit into from

Conversation

imjalpreet
Copy link

  1. New Test added for the function species_tuple_to_string()
  2. Some old tests are now changed to pytest parametrize.

@imjalpreet
Copy link
Author

@wkerzendorf, I have now changed my implementation to parameterize pytests. Do review whenever you are free.

@kaushik94
Copy link
Contributor

I don't understand why you have made the exact same PR as #234 ? Its already existing.

@imjalpreet
Copy link
Author

Actually, this is not a new pr it's just an updated version of #231

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 7473459 on imjalpreet:Tests into b298780 on tardis-sn:master.

@kaushik94
Copy link
Contributor

Yes, I can see that.

@wkerzendorf
Copy link
Member

@kaushik94 participants are allowed to open PRs to issues that are fixed by other PRs. Both of them can count towards applications. In this case as @imjalpreet said it was a successor of an existing PR.

@kaushik94
Copy link
Contributor

@wkerzendorf just take a look at #234 . Its not about two PRs solving the same thing here, its about two PRs being the same.

@wkerzendorf
Copy link
Member

@kaushik94 We'll look at these in detail later. None of them will be merged yet.

@kaushik94
Copy link
Contributor

@wkerzendorf sure, sorry for the trouble.

@wkerzendorf wkerzendorf closed this Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants