-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decay of isotopes branch #801
Conversation
[TEP007] [WIP] Isotope Abundances class
[TEP007] Isotope uniform config option
1. Note specifies the case when elemental and isotopic abundance is specified for the same element 2. Change CSV file used for docs to use space delimiter 3. Update abundances in CSV file, so that it sums to one.
1. Now first 4 columns are related to velocity,density,electron_densities,temperature. Abundances begin from 5th column onwards. 2. First line of abundances is ignored, same as in rest of cases for other abundance formats.
1. A common CSV file, containing quantities related to both abundances and density parser. 2. Changes in unit tests config files to reflect the same.
Since we are now using a common file for both
[TEP007] Decay and merge isotopic abundance dataframe
Now there is a line after header row, which contain quantites. It reads that line and convert attributes according to that quantity
[TEP007] Add cmfgen2tardis script
[TEP007] CMFGEN density parser
Fix for PR #801
@pfreddy @Heringer-Epson both of you will be using this feature. Have a look at the PR and familiarize yourself with it. |
@tardis-sn/core This is the decay branch that will add the ability to radioactively decay isotopes to TARDIS. @pfreddy has added some more fixes to make it work. I need someone else from the community to check this and then I'd be keen to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked over the source code and it looks fine to me. However, this PR unfortunately combines two main additions to the TARDIS which are unrelated, i.e. reading in CMFGEN files and handling the decay. In principle these should be two spearate PRs.
Concerning the decay capability - before finally signing off on this I want still want to test it.
*************** | ||
|
||
Convert CMFGEN files to TARDIS file format | ||
========================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the CMFGEN part has to do with the decay capabilities
This is the Isotopic decay branch of @vg3095 that unfortunately never got merged into TARDIS.
@tardis-sn/tardis-core please take a look.