Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(channel): open up channel length #138

Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix(channel): open up channel length #138

merged 1 commit into from
Apr 22, 2020

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Apr 22, 2020

❤ THANKS FOR HELPING OUT :D

Proposed change

Looks like channel id length has changed in some cases. This change will ease up on the length restriction. Will solve issue with some people seeing Unable to handle channel: UNKNOWN_* error messages.

Types of changes

What types of changes is this pull request introducing to flottbot? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

You can fill this out after creating your PR. Put an x in the boxes that apply

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@wass3r wass3r added slack slack remote specific bug Something isn't working labels Apr 22, 2020
@github-actions
Copy link

Pull Request Test Coverage Report for Build 8dfff1171c7a48a5425e27df1870220d2445b0d5-PR-138

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.71%

Changes Missing Coverage Covered Lines Changed/Added Lines %
remote/slack/util.go 0 1 0.0%
Totals Coverage Status
Change from base Build 51b2b525f8b5feccd0e254aa4aa6e591dddfd0f1: 0.0%
Covered Lines: 788
Relevant Lines: 1845

💛 - Coveralls

Copy link

@pa3ng pa3ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r wass3r merged commit b199cb6 into master Apr 22, 2020
@wass3r wass3r deleted the fix-channel-pattern branch April 22, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working slack slack remote specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants