notification: add alert summary to status updates #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastercactapus
requested changes
Jan 4, 2022
Forfold
commented
Jan 26, 2022
Forfold
requested review from
dctalbot and
mastercactapus
and removed request for
dctalbot and
mastercactapus
mastercactapus
previously approved these changes
Jan 31, 2022
Forfold
requested review from
mastercactapus and
dctalbot
and removed request for
dctalbot
# Conflicts: # go.mod
dctalbot
suggested changes
Feb 8, 2022
There was a problem hiding this comment.
Unable to run make start, looks like there are some unintended changes to go.mod? Got it to work using git checkout master -- go.mod
Also, the spacing is a bit odd now that I see it, I like the separation with the newlines, but the indentation isn't necessary IMO. If we do want to change, could go in a new issue potentially. For reference, here is my UX for an integration I named "web int":
|
@dctalbot what version of Go are you on? I had to update to 1.17. |
|
@dctalbot I see, well it's a result of |
dctalbot
approved these changes
Feb 8, 2022
mastercactapus
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the alert summary to status update messages. Status updates show the alert ID, but do not show the summary or provide a link to the alert, which can make the investigation of an alert cumbersome.
The current alert SMS template is conditionally rendering alert, alert bundle, and alert status messages, so I've made three explicit templates that can be leveraged when setting the type on the
alertSMSstruct before rendering. This should help with maintenance should we want to change any of the templates again.Which issue(s) this PR fixes:
Closes #2056