Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add runproc tool for dev use cases #2080

Merged
merged 9 commits into from
Jan 5, 2022
Merged

dev: add runproc tool for dev use cases #2080

merged 9 commits into from
Jan 5, 2022

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Jan 3, 2022

Description:
This PR adds the runproc tool which is a simpler alternative to runjson that uses a Procfile-style input instead of JSON. This is intended to make it easier for devs to add extra commands (e.g. ngrok or sendit) and maintain. Additionally the output uses colored prefix and original output which should be a better experience.

It also handles shutdown better/faster as well as the startup sequence lowering the amount of time a dev needs to wait.

image

Out of Scope

Only make start is using the new tool currently. start-prod and the cypress test commands are untouched and will be updated in further PRs with additional testing & validation.

Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome 🤩

devtools/runproc/signals.go Show resolved Hide resolved
devtools/runproc/signals_unix.go Show resolved Hide resolved
@m17ch m17ch self-requested a review January 5, 2022 21:51
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍
functionally validated

@mastercactapus mastercactapus merged commit b049471 into master Jan 5, 2022
@mastercactapus mastercactapus deleted the runproc branch January 5, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants