Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: Fix make start output #2172

Merged
merged 8 commits into from
Feb 16, 2022
Merged

dev: Fix make start output #2172

merged 8 commits into from
Feb 16, 2022

Conversation

mastercactapus
Copy link
Member

@mastercactapus mastercactapus commented Feb 16, 2022 •
edited
Loading

Description:
This PR fixes some noise issues in the log output.

  • Engine cycle is no longer logged by default
  • After 5 sec, warnings will be logged with an error at the end of the cycle
  • An error will be logged each minute if a cycle is stuck that long
  • "Build Failed" will be logged and retried after 3sec on failure with make start instead of exiting
  • Prometheus is changed to warn log level
  • Cypress tests should no longer spam make messages

Which issue(s) this PR fixes:
Fixes #2156
Fixes #2157

Out of Scope
Request logging has been left out and can be addressed separately (or with #2106 )

@mastercactapus mastercactapus marked this pull request as ready for review February 16, 2022 19:45
@dctalbot dctalbot mentioned this pull request Feb 16, 2022
Closed
7 tasks
@arurao arurao self-requested a review February 16, 2022 21:31
arurao
arurao approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@arurao arurao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastercactapus mastercactapus merged commit a2e1ddd into master Feb 16, 2022
@mastercactapus mastercactapus deleted the fix-make-start-output branch February 16, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dctalbot dctalbot dctalbot approved these changes

@arurao arurao arurao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: fix make start exit on Go build error dev: fix cy-wide-prod-run and cy-mobile-prod-run output
3 participants
@mastercactapus @dctalbot @arurao